chore: test cleanup #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
imdhemy
commented
Dec 28, 2025
imdhemy
commented
| Q | A |
|---|---|
| License | GPLv3 |
| Issue | Closes #<issue_number> |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes and consolidates test files by moving end-to-end tests from the monolithic ApplicationFactory.test.ts into focused, feature-specific e2e test files. The changes also refactor ApplicationFactory.ts to add the httpKernel middleware and improve conditional logic.
Key Changes:
- Created 5 new e2e test files to replace comprehensive tests previously in
ApplicationFactory.test.ts - Removed
RegisterEventSubscribers.test.tswith functionality covered by new e2e tests - Simplified
ApplicationFactory.test.tsto only test basic app creation - Updated
ApplicationFactory.tsto registerhttpKernelmiddleware and add null-safety checks - Simplified upgrade documentation
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/serve-static-files.e2e.test.ts | New e2e tests for serving static text and image files |
| tests/routing.e2e.test.ts | New e2e test for global middleware registration |
| tests/request-props.e2e.test.ts | New e2e tests for accessing request properties (body, params, headers, files) |
| tests/generate-response.e2e.test.ts | New e2e test for basic response generation with status, body, and headers |
| tests/event-subscribers.e2e.test.ts | New e2e tests for single and multiple event subscribers |
| tests/RegisterEventSubscribers.test.ts | Removed - functionality moved to event-subscribers.e2e.test.ts |
| src/Application/ApplicationFactory.ts | Added httpKernel middleware registration and improved null-safety with conditional checks |
| src/Application/ApplicationFactory.test.ts | Simplified to only test basic app creation, with comprehensive tests moved to e2e files |
| UPGRADE-3.0.md | Simplified Event module migration instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
imdhemy
added a commit
that referenced
this pull request
Jan 2, 2026
* chore: remove unnecessary test * chore: add end-to-end test for response generation * chore: add end-to-end tests for request properties and file uploads * chore: add end-to-end tests for serving static files * feat(kernel): integrate http kernel into the app * chore: add end-to-end test for global middleware registration * chore: enhance ApplicationFactory with event subscriber handling and add tests * chore: update upgrade docs * chore(config): disable dotenv logs * chore: fix typo * chore: add test for async event subscriber * chore: test non parsed body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.