-
Notifications
You must be signed in to change notification settings - Fork 1
feat(kernel): replace event bus middleware with http kernel #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9c74613
feat(kernel): replace event bus middleware with http kernel
imdhemy 58781f9
chore(docs): add migration guide for upgrading from 2.x to 3.0
imdhemy bf79132
chore(bc): export additional types for event bus middleware
imdhemy ef5e4a8
docs: update upgrade guide to reflect event bus middleware removal an…
imdhemy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Upgrade from 2.x to 3.0 | ||
|
|
||
| # Event | ||
|
|
||
| - Remove `eventBusMiddleware` and use `httpKernel` instead. | ||
| - Replace all the types from `@koala-ts/framework/Event` with types from `@koala-ts/framework/Kernel`. | ||
|
|
||
| ```diff | ||
| -- import { eventBusMiddleware } from '@koala-ts/framework/Event'; | ||
| ++ import { httpKernel } from '@koala-ts/framework/Kernel'; | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,12 @@ | ||
| export * from './types'; | ||
| export * from './EventBus'; | ||
| /** | ||
| * @deprecated This module is deprecated in favor of using the Kernel module. | ||
| */ | ||
| export { httpKernel as eventBusMiddleware } from '@/Kernel/HttpKernel'; | ||
| export type { | ||
| KernelStorage as EventBusStorage, | ||
| EventEmitter, | ||
| EventSubscriber, | ||
| useEmit, | ||
| useResponse, | ||
| useRequest, | ||
| } from '@/Kernel'; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { | ||
| createStore, | ||
| type HttpRequest, | ||
| type HttpResponse, | ||
| type HttpScope, | ||
| type NextMiddleware, | ||
| type ScopeStore, | ||
| } from '@/Http'; | ||
| import { type EventEmitter, type KernelStorage } from '@/Kernel/types'; | ||
|
|
||
| const kernelStorage = createStore<KernelStorage>(); | ||
|
|
||
| export async function httpKernel( | ||
| scope: HttpScope, | ||
| next: NextMiddleware, | ||
| storage: ScopeStore<KernelStorage> = kernelStorage, | ||
| ): Promise<void> { | ||
| await storage.run({ eventEmitter: scope.app, scope }, next); | ||
| } | ||
|
|
||
| export function useEmit(storage: ScopeStore<KernelStorage> = kernelStorage): EventEmitter { | ||
| return storage.get('eventEmitter'); | ||
| } | ||
|
|
||
| export function useRequest(storage: ScopeStore<KernelStorage> = kernelStorage): HttpRequest { | ||
| return storage.get('scope').request; | ||
| } | ||
|
|
||
| export function useResponse(storage: ScopeStore<KernelStorage> = kernelStorage): HttpResponse { | ||
| return storage.get('scope').response; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export * from './types'; | ||
| export * from './HttpKernel'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.