-
Notifications
You must be signed in to change notification settings - Fork 14
Update dependencies & remove deprecated APIs #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
knz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
I’ve updated the PR and restored BackgroundStyle as a deprecated |
knz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks
|
As you can see the CI rules are also very old and don't work anymore. I'm going to merge this PR, but would be very grateful if you could also update the github workflows as well. |
|
Thanks for merging! I'll follow up with a separate PR to update the CI to current Go and Actions versions. |
|
could you please confirm which Go version (or range) you’d like the CI to target ? |
|
please decide - typical versions for current users of bubbletea |
|
I encountered an error on testing https://github.com/Balaji01-4D/bubbline/actions/runs/19597828530/job/56124885239 |
|
thanks, please rebase |
|
Rebased and opened the CI update PR. Everything is passing. Thanks! |
This PR includes two small maintenance updates:
Fix compatibility with charmbracelet/bubbles after BackgroundStyle was removed (ref: e4e3137).
Refactor deprecated ioutil.TempFile usage to os.CreateTemp (Go 1.17+).
These changes improve compatibility with newer versions and remove deprecated APIs without affecting existing behavior.