Skip to content

Conversation

@Balaji01-4D
Copy link
Contributor

This PR includes two small maintenance updates:

  • Fix compatibility with charmbracelet/bubbles after BackgroundStyle was removed (ref: e4e3137).

  • Refactor deprecated ioutil.TempFile usage to os.CreateTemp (Go 1.17+).

These changes improve compatibility with newer versions and remove deprecated APIs without affecting existing behavior.

Copy link
Owner

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Balaji01-4D
Copy link
Contributor Author

Balaji01-4D commented Nov 21, 2025

I’ve updated the PR and restored BackgroundStyle as a deprecated

Copy link
Owner

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks

@knz
Copy link
Owner

knz commented Nov 21, 2025

As you can see the CI rules are also very old and don't work anymore. I'm going to merge this PR, but would be very grateful if you could also update the github workflows as well.

@knz knz merged commit bab2b76 into knz:main Nov 21, 2025
0 of 8 checks passed
@Balaji01-4D
Copy link
Contributor Author

Thanks for merging! I'll follow up with a separate PR to update the CI to current Go and Actions versions.

@Balaji01-4D
Copy link
Contributor Author

could you please confirm which Go version (or range) you’d like the CI to target ?

@knz
Copy link
Owner

knz commented Nov 22, 2025

please decide - typical versions for current users of bubbletea

@Balaji01-4D
Copy link
Contributor Author

@knz
Copy link
Owner

knz commented Nov 28, 2025

thanks, please rebase

@Balaji01-4D
Copy link
Contributor Author

Rebased and opened the CI update PR. Everything is passing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants