Skip to content

fix tracing computation of valid nodes #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aannleax merged 1 commit into from
Nov 24, 2025
Merged

fix tracing computation of valid nodes #750

aannleax merged 1 commit into from
Nov 24, 2025

Conversation

@aannleax
Copy link
Member

@aannleax aannleax commented Nov 21, 2025

Fixes a bug in type 2 tracing where operations would not get applied correctly during the bottom-up phase.

Also addresses an issue where ids would be assigned inconsistently between the two tracing types (see #747).

@aannleax aannleax added this to the Release 0.10.0 milestone Nov 21, 2025
@aannleax aannleax self-assigned this Nov 21, 2025
@aannleax aannleax added bug Something isn't working tracing Issue related to tracing of derived facts labels Nov 21, 2025
@aannleax aannleax added this to nemo Nov 21, 2025
@github-project-automation github-project-automation bot moved this to Todo in nemo Nov 21, 2025
monsterkrampe
monsterkrampe approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@monsterkrampe monsterkrampe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also extending the expect messages. Much appreciated!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in nemo Nov 24, 2025
@aannleax aannleax merged commit 9de82e2 into main Nov 24, 2025
8 checks passed
@aannleax aannleax deleted the bug/tracing-valid-nodes branch November 24, 2025 09:40
@github-project-automation github-project-automation bot moved this from In Progress to Done in nemo Nov 24, 2025
@aannleax aannleax mentioned this pull request Nov 24, 2025
Closed
@monsterkrampe monsterkrampe mentioned this pull request Nov 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@monsterkrampe monsterkrampe monsterkrampe approved these changes

Assignees

@aannleax aannleax

Labels

bug Something isn't working tracing Issue related to tracing of derived facts

Projects

nemo
Archived in project

Milestone

Release 0.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@aannleax @monsterkrampe