Skip to content

Conversation

@sasjonge
Copy link
Collaborator

No description provided.

@sasjonge sasjonge requested a review from Copilot April 17, 2025 13:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • CMakeLists.txt: Language not supported
  • Dockerfile: Language not supported
  • action/Tell.action: Language not supported
  • msg/GraphQueryMessage.msg: Language not supported
  • msg/ModalFrame.msg: Language not supported
  • msg/TellMessage.msg: Language not supported
  • msg/Triple.msg: Language not supported
Comments suppressed due to low confidence (1)

src/ROSInterface.cpp:324

  • Consider adding a check for an empty 'goal->tell.triples' before creating the conjunction. An empty list might lead to unintended behavior when constructing the conjunction formula.
FormulaPtr phi = std::make_shared<Conjunction>(formulas);

@sasjonge sasjonge merged commit a2ac220 into knowrob:ros1 Apr 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant