Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audited our Sequelize models against the rest of the codebase (imports, includes, queries, client code, workers, etc.) and removed everything that has zero runtime usage. These only existed in model definitions, type schemas, and old migration scripts under
tools/.Before merging, I wan to confirm with the team: does anyone know of external scripts, cron jobs, or direct DB queries that reference any of the below?
Removed tables (6)
CommunityAdminsensureUserIsCommunityAdminutility is unrelated (it checks the Member model).Mergestools/migration scripts.OrganizationsscopeGet.tsexplicitly throws "No such thing as an organization". Community had aBelongsTo Organizationassociation that was never included in any query.PubManagersPubVersionsHasMany PubVersionassociation that was never used in any include. Only referenced in oldtools/scripts.ThreadUserssequelize.addModels(). Completely orphaned.Removed columns (7)
UsersinactiveUserspubpubV3IdCommunitiesorganizationIdMembersorganizationIdcreateMember(). ClientuseMembersread it but it was always null — that code is also cleaned up here.PublicPermissionsorganizationIdReleaseshistoryKeyMissingReviewNewslabelsOther cleanup
DashboardMembers(including two@ts-expect-errorcomments that acknowledged Organizations "aren't really a thing anymore")PubVersiontype export fromtypes/pub.ts