feat: Add setting to enforce comments on timesheets#126
Draft
akash2017sky wants to merge 2 commits intomainfrom
Draft
feat: Add setting to enforce comments on timesheets#126akash2017sky wants to merge 2 commits intomainfrom
akash2017sky wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new user setting to require notes/comments on time entries, and enforces it in both the time entry modal and timesheet submission flow.
Changes:
- Adds
requireTimesheetCommentstoUserSettingsand initializes it in the settings store defaults. - Adds a Settings toggle to enable/disable requiring comments on time entries.
- Enforces the setting by validating notes on save (modal) and blocking timesheet submission when any entry is missing notes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/index.ts | Extends UserSettings with requireTimesheetComments. |
| src/hooks/useSettingsStore.ts | Adds default value for the new setting in the persisted settings store. |
| src/components/timesheet/WeeklyTimesheet.tsx | Blocks submission when the setting is enabled and entries are missing notes. |
| src/components/timesheet/TimeEntryModal.tsx | Validates notes presence when the setting is enabled and updates UI labeling/required flag. |
| src/components/settings/SettingsPanel.tsx | Adds a UI toggle wired to useSettingsStore to control the setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@akash2017sky please take a look above! |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Tested, Copilot review comments addressed. @BenGWeeks please merge |
EdiWeeks
approved these changes
Feb 12, 2026
Contributor
|
Architecturally this is storing in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Closes #66
Test plan