-
Notifications
You must be signed in to change notification settings - Fork 14
fix: add polling to make OAuth flows more robust to popup communication failure #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add polling to make OAuth flows more robust to popup communication failure #830
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6dce500 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4bee0c3 to
3350098
Compare
3350098 to
0c0dc93
Compare
0c0dc93 to
80abaad
Compare
29514c0 to
b7508c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍩
packages/react/src/modules/ms-teams/components/MsTeamsAuthButton/MsTeamsAuthButton.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/modules/ms-teams/components/MsTeamsAuthButton/MsTeamsAuthButton.tsx
Outdated
Show resolved
Hide resolved
f110a05 to
6999528
Compare
6999528 to
6dce500
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
==========================================
+ Coverage 67.84% 68.45% +0.60%
==========================================
Files 190 193 +3
Lines 7934 8052 +118
Branches 1041 1062 +21
==========================================
+ Hits 5383 5512 +129
+ Misses 2526 2515 -11
Partials 25 25
|
Description
In some cases,
window.postMessagefails, so this PR adds some polling to see if the connection has been established.Checklist
Screenshots or videos
Example where I hard-coded the popup HTML response to not auto close or send the success message. The button updating to 'Connected' and closing the popup is from the polling codepath.
https://github.com/user-attachments/assets/bc411148-643d-4e8a-9175-d567ac37a25c