Skip to content

fix(KNO-11403): Update path sync effect so it sets isOpen from the current path #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rachael-t wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(KNO-11403): Update path sync effect so it sets isOpen from the current path #1289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions components/ui/Page/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,21 +81,19 @@ const ItemWithSubpages = ({
defaultOpen ?? getOpenState(section.pages ?? [], slug, pathNoHash),
);

// Update isOpen when the path changes
// Update isOpen when the path changes (e.g. after client-side navigation from search)
useEffect(() => {
// Have to do an initialization check like this so we can control it manually still
if (pathNoHash !== initializedOnPath) {
setInitializedOnPath(pathNoHash);
if (!isOpen) {
const isDeterminedOpen = getOpenState(
section.pages ?? [],
slug,
pathNoHash,
);
setIsOpen(defaultOpen ?? isDeterminedOpen);
}
const isDeterminedOpen = getOpenState(
section.pages ?? [],
slug,
pathNoHash,
);
setIsOpen(defaultOpen ?? isDeterminedOpen);
}
}, [section, slug, pathNoHash, isOpen, defaultOpen, initializedOnPath]);
}, [section, slug, pathNoHash, defaultOpen, initializedOnPath]);

// Create the debounced function once when component mounts
// This helps produce a smoother experience when scrolling fast
Expand Down
Loading