Skip to content

🧪 Add test for invalid snapshot JSON manifest structure #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bashandbone merged 3 commits into from
Mar 13, 2026
Merged

🧪 Add test for invalid snapshot JSON manifest structure #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b3457e
test: Add test for invalid snapshot JSON manifest structure
google-labs-jules[bot] Mar 13, 2026
98cf3d6
chore: Fix linting error on test fixture
google-labs-jules[bot] Mar 13, 2026
148452e
Merge branch 'main' into fix/snapshot-invalid-json-test-1301691887695…
bashandbone Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ convention = "google"

[lint.per-file-ignores]
"tests/fixtures/sample_type_aliases.py" = [
"UP040", # Type alias uses `TypeAlias` annotation instead of the `type` keyword
"UP040", # Intentionally using TypeAlias for backwards compatibility testing
]
"tests/*.py" = [
"ANN",
Expand Down
9 changes: 9 additions & 0 deletions tests/test_snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,3 +147,12 @@ def test_read_manifest_returns_none_on_invalid_types(self, manager):
# Should be a dict, not a list
manager.manifest_path.write_text("[]", encoding="utf-8")
assert manager.read_manifest() is None

def test_read_manifest_returns_none_on_invalid_entry_format(self, manager):
manager.snapshot_dir.mkdir(parents=True, exist_ok=True)
# Entry missing required keys will raise TypeError in SnapshotEntry(**e)
manager.manifest_path.write_text(
'{"timestamp": "2024-01-01T00:00:00Z", "entries": [{"invalid_key": "value"}]}',
encoding="utf-8",
)
assert manager.read_manifest() is None
Loading