-
Notifications
You must be signed in to change notification settings - Fork 68
Add meson as build system #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7fd5cb0 to
5883de9
Compare
|
Thank you very much for your effort! Honestly, I'd prefer if we could change the build system to CMake instead. Not because I love CMake so much (I don't), but because faac's sister project faad2 already uses this as its build system. But anyway, I am thankful for any contribution. |
|
@fabiangreffrath hi, well sorry you'll never see me porting a project to cmake on purpose, it is a so unreliable software that I don't understand why people still use it (everybody hates cmake team). I'd rather port faad2 to meson instead... I did this PR mostly because I wanted to have faac support in FreeRDP on windows with the msvc toolchain done in accendino. And that's the only way I found to correctly automate the build (so build libraries and install headers), except if I missed something the vcxproj don't allow that. |
fabiangreffrath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you port the CI to use meson as well, please?
31c2570 to
abd8baf
Compare
This patch adds meson build files so that you can also build using meson. This may help building under windows with VS and allow to install files.
fabiangreffrath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
|
Ha ha seems like I've started a revolution with that meson PR ;-) |
|
Well, at least it triggered some long overdue changes. 😉 |
This patch adds meson build files so that you can also build using meson. This may help building under windows with VS and allow to install files.