Skip to content

Conversation

@hardening
Copy link
Contributor

This patch adds meson build files so that you can also build using meson. This may help building under windows with VS and allow to install files.

@hardening hardening force-pushed the meson branch 2 times, most recently from 7fd5cb0 to 5883de9 Compare December 8, 2025 07:10
@fabiangreffrath
Copy link
Collaborator

Thank you very much for your effort!

Honestly, I'd prefer if we could change the build system to CMake instead. Not because I love CMake so much (I don't), but because faac's sister project faad2 already uses this as its build system. But anyway, I am thankful for any contribution.

@hardening
Copy link
Contributor Author

@fabiangreffrath hi, well sorry you'll never see me porting a project to cmake on purpose, it is a so unreliable software that I don't understand why people still use it (everybody hates cmake team). I'd rather port faad2 to meson instead...

I did this PR mostly because I wanted to have faac support in FreeRDP on windows with the msvc toolchain done in accendino. And that's the only way I found to correctly automate the build (so build libraries and install headers), except if I missed something the vcxproj don't allow that.

Copy link
Collaborator

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you port the CI to use meson as well, please?

@hardening hardening force-pushed the meson branch 5 times, most recently from 31c2570 to abd8baf Compare December 8, 2025 09:47
This patch adds meson build files so that you can also build using meson.
This may help building under windows with VS and allow to install files.
Copy link
Collaborator

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@fabiangreffrath fabiangreffrath merged commit 7ef7235 into knik0:master Dec 8, 2025
4 checks passed
@hardening
Copy link
Contributor Author

Ha ha seems like I've started a revolution with that meson PR ;-)

@fabiangreffrath
Copy link
Collaborator

Well, at least it triggered some long overdue changes. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants