Fixing the Decay String for GeomDecay#41
Merged
nkapila6 merged 2 commits intoknakamura13:mainfrom May 13, 2025
Merged
Conversation
Collaborator
|
Nice find! Can you fix the corresponding test too? https://github.com/knakamura13/mlrose-ky/actions/runs/13536033580/job/37828163496?pr=41 |
Collaborator
|
I need to see why it was implemented this way because the repr method gives out the correct class name. https://github.com/knakamura13/mlrose-ky/blob/main/src/mlrose_ky/algorithms/decay/geom_decay.py |
Author
|
Sure, please confirm if there is any reason why its done like that. the repr in other decay just calls the str method. I will wait for your confirmation before updating the test case. |
Author
fixed the test case as well. |
Collaborator
|
Looks good to me. Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeomDecay String method is giving only the initTemp and not the entire string thus not matching ArithDecay and ExpDecay. Fixing the same for consistency and correct result string.