Skip to content

update Market.trades() to be able to set offset #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
komori556 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update Market.trades() to be able to set offset #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea160a5
update Market.trades() to be able to set offset
komori556 Aug 25, 2017
485e6a6
modify to limit offset_max_value in Market.trades()
komori556 Aug 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions coincheck/market.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,30 @@ def __init__(self):
pass


def public_api(self,url):
def public_api(self,url,offset=0):
''' template function of public api'''
params = {}
if(offset>0):
params = {'offset':offset}
if(offset>99):
offset=99
try :
url in api_urls
return ast.literal_eval(requests.get(base_url + api_urls.get(url)).text)
return ast.literal_eval(requests.get(base_url + api_urls.get(url),params=params).text)
except Exception as e:
print(e)

def ticker(self):
'''get latest information of coincheck market'''
return self.public_api('ticker')
def trades(self):
return self.public_api('ticker')

def trades(self,offset = 0):
'''get latest deal history of coincheck market'''
return self.public_api('trades')
return self.public_api('trades',offset)

def orderbooks(self):
'''get latest asks/bids information of coincheck market'''
return self.public_api('order_books')
return self.public_api('order_books')


if __name__ == '__main__':
Expand Down