Add calendars to schedule EVU, hot water block and reduced temperature #48
Open
hashtagKnorke wants to merge 25 commits intoklejejs:mainfrom
Open
Add calendars to schedule EVU, hot water block and reduced temperature #48hashtagKnorke wants to merge 25 commits intoklejejs:mainfrom
hashtagKnorke wants to merge 25 commits intoklejejs:mainfrom
Conversation
incoming change from upstream
…ATA_DURING_TEST flag
…reference separate section
klejejs
requested changes
Dec 23, 2024
Owner
klejejs
left a comment
There was a problem hiding this comment.
Thank you for attempting to add the calendar feature to the API. Overall, it looks good, however, I added some comments for improvements.
Also, please run the linter black ThermiaOnlineAPI/ to lint the changes and it would be nice to look into adding some tests for this as well.
… class - introduce getters and make properties private
- function order re-sorted - add get_supported_calendar_functions method
…hedule, updating methods for calendar functionality
…play supported calendar functions
hashtagKnorke
commented
Dec 26, 2024
Author
hashtagKnorke
left a comment
There was a problem hiding this comment.
all comments should now be resolved or justified in conversation
… modules by running linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the additions provide APIs to set a certain schedule
tested on an