Skip to content

Comments

bugfix(KLEF): Localization#120

Merged
NathanRoos merged 2 commits intomainfrom
bugfix/KLEF_Fix_Localisation_Dashboard
Feb 23, 2026
Merged

bugfix(KLEF): Localization#120
NathanRoos merged 2 commits intomainfrom
bugfix/KLEF_Fix_Localisation_Dashboard

Conversation

@NathanRoos
Copy link
Contributor

🚀 Pull Request Overview

📌 Summary

🔗 Related Issues

Closes #


🧪 Changes

✅ What’s Included

❌ What’s Not Included


🧪 Testing

🔍 How Was This Tested?

🧪 Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • End-to-end scenarios tested manually

🧩 Breaking Changes

Does this PR introduce breaking changes?

  • Yes
  • No

If yes, describe the impact and migration steps:


🔐 Security Considerations

  • This PR affects authentication or authorization
  • This PR touches secrets, tokens, or environment variables
  • This PR affects infrastructure or deployment pipeline

If checked, explain:


📝 Documentation

Does this PR require updates to documentation?

  • Yes
  • No

If yes, update the relevant locations:

  • /docs
  • README.md
  • API reference
  • Architecture diagrams / C4 / DDD docs

🎨 UI/UX Considerations (If Applicable)

  • Includes new components
  • Changes styles or theme tokens
  • Requires design approval
  • Responsive behavior tested

Screenshots / recordings (if applicable):


📦 Checklist Before Merge

  • Follows project coding style
  • PR title follows semantic format (feat:, fix:, chore:, docs:, refactor:, test:)
  • All CI checks passing
  • No debug logs or commented-out code
  • Dependencies reviewed
  • No sensitive information added

👤 Contributor Notes (Optional)

@NathanRoos NathanRoos self-assigned this Feb 23, 2026
Copilot AI review requested due to automatic review settings February 23, 2026 09:15
@github-actions github-actions bot added the bugfix Bug fix label Feb 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to add localization support to the dashboard and tutorial components by integrating French and English translations. However, the PR contains critical issues that need to be addressed before merging.

Changes:

  • Added localization support to DashboardPage and TutorialSheet components
  • Added tutorial-related translation keys to English and French locale files
  • Unintentionally modified yarn.lock with platform-specific package changes

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
frontend/yarn.lock Contains unintentional platform-specific package changes from darwin-arm64 to win32-x64 that should be reverted
frontend/src/pages/dashboard/components/TutorialSheet.tsx Adds localization to tutorial sheet with translation imports and fallback logic (contains critical bugs)
frontend/src/pages/dashboard/DashboardPage.tsx Integrates translations for dashboard UI elements and labels (contains bugs and maintainability issues)
frontend/src/app/locales/en/dashboard.json Adds English tutorial translations with minor indentation inconsistencies
frontend/src/app/locales/fr/dashboard.json Adds French tutorial translations with minor indentation inconsistencies
Comments suppressed due to low confidence (1)

frontend/src/pages/dashboard/components/TutorialSheet.tsx:121

  • The fallback logic will never render JSX elements when translations are missing. When t?.tutorial_create_desc is undefined/null, the JSX expression in parentheses will be evaluated immediately, but the logical OR operator will not properly handle JSX as a fallback value. This will result in rendering "[object Object]" or an error instead of the intended fallback content.
                src="/assets/tutorial/project-resources.png"
                alt="Project resource usage table"
                onClick={handleImageClick}
              />
            </section>

            <section className="space-y-3">

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NathanRoos NathanRoos merged commit a6133cf into main Feb 23, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants