This repository was archived by the owner on Mar 19, 2021. It is now read-only.
Implemented option to use different providers for checking item prices#42
Open
ForsakenNGS wants to merge 1 commit intoklayver:masterfrom
Open
Implemented option to use different providers for checking item prices#42ForsakenNGS wants to merge 1 commit intoklayver:masterfrom
ForsakenNGS wants to merge 1 commit intoklayver:masterfrom
Conversation
- Added various data that can be grabbed from the official poe trading api and wiki - Added advanced item parser (including item mods, min-/max-rolls, sockets, ...) - Added first implementation of price checking for the official poe trading api - "src/resource/modPseudoMappings.json" contains some rules for combining certain mods into pseudo-mods when searching or ignoring some in certain cases - "src/modules/poetrade.js" function "getSearchQuery" contains the core logic for setting up the search parameters - Added the possibility to add multiple providers for price estimations, which will automatically fallback on failure - Added notice about max rolled mods (always relative to the mod tier)
|
This looks great ! Any update on accepting the pull request ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we go again ;-) I refactored a lot and extracted the most complex functionality into it's seperate npm module. (See https://github.com/ForsakenNGS/PoeData - documentation is still a todo, but the classes are pretty clean imho)
I also added automatic fallbacks in case of failure, a cleaner settings section and a few optimizations for the search e.g. an implementation for scarab search (see #31 )
If there are still issues, questions or constructive feedback feel free to contact me :)