Patches for Embarcadero C++ Builder (classic Borland compiler).#47
Open
nased0 wants to merge 2 commits intokkAyataka:masterfrom
Open
Patches for Embarcadero C++ Builder (classic Borland compiler).#47nased0 wants to merge 2 commits intokkAyataka:masterfrom
nased0 wants to merge 2 commits intokkAyataka:masterfrom
Conversation
Small code corrections to allow compilation by Borland BCC32.exe compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small code changes to allow compilation by the Borland BCC32.exe compiler and to eliminate a warning about a signed/unsigned comparison.
BCC32.exe compiler is still used in Embarcadero C++ Builder 12.
In function encrypt_cb iv is now just a pointer to an array of 16 bytes. Borland's compiler does not accept current notation, and there is no reason for it. Besides, if current argument iv is a pointer to a pointer to an array of bytes, then checking if iv is not null does not ensure that *iv that is an argument to a function detail::xor_data(s, *iv) is not null.