Skip to content

Revert commit 2239dde - restore simpler task completion logic#99

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/revert-commit-2239dde
Closed

Revert commit 2239dde - restore simpler task completion logic#99
Copilot wants to merge 2 commits intomainfrom
copilot/revert-commit-2239dde

Conversation

Copy link
Contributor

Copilot AI commented Oct 9, 2025

This PR reverts commit 2239dde ("fix: Improve task completion and exit logic in RunSubgraph. Closes #95") which introduced enhanced task tracking and exit logic.

Changes Reverted

The revert undoes the following changes to internal/run.go:

1. Dual Task Tracking

Removes the remainingTasks map that was added alongside pendingTasks. The original code used only pendingTasks for simpler exit condition handling.

2. Task Failure Handling Order

Restores the original order where failed task checking happens after pending task completion checks, rather than at the beginning of the loop with early exit.

3. Log Messages

Reverts enhanced logging with emoji indicators back to plain text:

  • 🚫 exiting because task %q failed...exiting because task %q should not be restarted...
  • ✅ exiting because all requested tasks completed...exiting because all requested tasks completed...
  • Removes 🔵 all requested tasks are running: message and port listing

4. Service Completion Logic

Removes the complex switch statement that treated services as complete when in "running" or "stalled" state. The original logic only considered tasks complete when "succeeded" or "skipped".

5. Poison Pill Event

Removes events <- poisonPill from the setNodeStatus function, restoring the original behavior where status updates don't trigger poison pill events.

Verification

  • ✅ All 16 TestRunSubgraph subtests pass
  • ✅ All repository tests pass
  • ✅ Code properly formatted with goimports
  • ✅ No issues found by go vet
  • ✅ Stats: 17 insertions(+), 40 deletions(-) (exact inverse of commit 2239dde)

This revert restores the simpler, original task completion and exit logic that was in place before commit 2239dde.

Original prompt

Revert commit 2239dde.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Copilot AI changed the title [WIP] Revert commit 2239dde Revert commit 2239dde - restore simpler task completion logic Oct 9, 2025
Copilot AI requested a review from alexec October 9, 2025 22:26
@alexec alexec closed this Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display a list of ready services, when everything is ready

2 participants