Revert commit 2239dde - restore simpler task completion logic#99
Closed
Revert commit 2239dde - restore simpler task completion logic#99
Conversation
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Revert commit 2239dde
Revert commit 2239dde - restore simpler task completion logic
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts commit 2239dde ("fix: Improve task completion and exit logic in RunSubgraph. Closes #95") which introduced enhanced task tracking and exit logic.
Changes Reverted
The revert undoes the following changes to
internal/run.go:1. Dual Task Tracking
Removes the
remainingTasksmap that was added alongsidependingTasks. The original code used onlypendingTasksfor simpler exit condition handling.2. Task Failure Handling Order
Restores the original order where failed task checking happens after pending task completion checks, rather than at the beginning of the loop with early exit.
3. Log Messages
Reverts enhanced logging with emoji indicators back to plain text:
🚫 exiting because task %q failed...→exiting because task %q should not be restarted...✅ exiting because all requested tasks completed...→exiting because all requested tasks completed...🔵 all requested tasks are running:message and port listing4. Service Completion Logic
Removes the complex switch statement that treated services as complete when in "running" or "stalled" state. The original logic only considered tasks complete when "succeeded" or "skipped".
5. Poison Pill Event
Removes
events <- poisonPillfrom thesetNodeStatusfunction, restoring the original behavior where status updates don't trigger poison pill events.Verification
This revert restores the simpler, original task completion and exit logic that was in place before commit 2239dde.
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.