Move rejection component#745
Merged
stackoverfloweth merged 1 commit intorejection-setTitlefrom Mar 23, 2026
Merged
Conversation
pleek91
reviewed
Mar 22, 2026
Contributor
There was a problem hiding this comment.
I don't understand why we need this here. Shouldn't the notFoundRejection already have a route?
pleek91
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds upon the same idea of setTitle on rejections. By leaning into the rejections underlying route, we can pull the
componentoff the route as well. This is a pretty minor change, but I think it's nicer to have a simpler surface type for rejection and continue to make it powered by the underlying route.