Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/compare-to-tanstack.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Migrating from Tanstack

- no keys, caches function + arguments by default
- no keys (tags don't require user to adopt naming scheme), caches function + arguments by default
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know both these libraries and this is confusing to me. I'd keep it as no keys. Because in tanstack keys are required to even make a query. You don't need to use tags at all. In fact some simple apps I'd expect to not need tags.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is not done, just taking notes along the way

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe don't commit unfinished pages or mark things that don't need reviewed. Just so I can skip them

2 changes: 1 addition & 1 deletion docs/core-concepts/queries.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ The `useQuery` function adds some super useful, vue specific functionality you'd

### Parameters argument is reactive

When parameters for your query function change, the query is automatically updated.
The parameters for your query must be provided as a getter, which ensures they are reactive. When the parameters change, the query is automatically updated. The old query is disposed and a new query is created.

```ts
import { useQuery } from '@kitbag/query'
Expand Down
Loading