-
-
Notifications
You must be signed in to change notification settings - Fork 0
Documentation - Tags & Invalidation #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0b31991
export everything on default client
stackoverfloweth 8f5eb6f
update queries to reflect recent changes to params syntax
stackoverfloweth 798051e
updated page for tags & invalidation
stackoverfloweth 65a4cba
code review suggestions
stackoverfloweth f620943
Merge branch 'main' into docs-tags
stackoverfloweth 6162085
Update docs/core-concepts/tags-invalidation.md
stackoverfloweth a26edef
code review suggestions
stackoverfloweth 2750e58
Update docs/core-concepts/tags-invalidation.md
stackoverfloweth 98dce67
code review suggestions
stackoverfloweth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| # Migrating from Tanstack | ||
|
|
||
| - no keys, caches function + arguments by default | ||
| - no keys (tags don't require user to adopt naming scheme), caches function + arguments by default | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know both these libraries and this is confusing to me. I'd keep it as no keys. Because in tanstack keys are required to even make a query. You don't need to use tags at all. In fact some simple apps I'd expect to not need tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is not done, just taking notes along the way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe don't commit unfinished pages or mark things that don't need reviewed. Just so I can skip them