Add support for abort signals when calling on and once#26
Merged
Conversation
✅ Deploy Preview for kitbag-events ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stackoverfloweth
approved these changes
Feb 16, 2025
Contributor
stackoverfloweth
left a comment
There was a problem hiding this comment.
very nice 👏
got a few small code suggestions but nothing I feel super strongly about
Co-authored-by: Evan Sutherland <stackoverfloweth@gmail.com>
Co-authored-by: Evan Sutherland <stackoverfloweth@gmail.com>
Co-authored-by: Evan Sutherland <stackoverfloweth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When stopping event handlers its often useful to be able to stop multiple listeners at the same time. By adding support for abort signals multiple handlers can be stopped at once without having to call multiple off callbacks.
Note: I also organized some test coverage and added some missing test cases to unify testing around
on,once, andnext`