feat: added support for a custom endpoint url#183
Open
amitassaraf wants to merge 1 commit intokislyuk:mainfrom
Open
feat: added support for a custom endpoint url#183amitassaraf wants to merge 1 commit intokislyuk:mainfrom
amitassaraf wants to merge 1 commit intokislyuk:mainfrom
Conversation
Author
|
@kislyuk FYI |
o-nikolas
reviewed
Feb 9, 2023
| @@ -249,11 +254,15 @@ def __init__( | |||
| # Creating the client should be the final call in __init__, after all instance attributes are set. | |||
| # This ensures that failing to create the session will not result in any missing attribtues. | |||
| if boto3_client is None and boto3_profile_name is None: | |||
Contributor
There was a problem hiding this comment.
Can you add some unit tests that assert these 4 branches (that the client has the custom end point when expected and throws a warning when expected, etc).
Owner
|
I am open to merging this but I agree this needs a test case to assert the respective behaviors. Can you please add one? |
Owner
|
@amitassaraf any luck adding a test? Thanks again for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR; Added support to provide a custom endpoint URL to the boto3 clients in case you are using a dict config / yaml file. This was not possible previously.