Feature/pdf viewer #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loqimean
requested changes
Nov 28, 2023
app/controllers/books_controller.rb
Outdated
|
|
||
| def show | ||
| @book = resource | ||
| @adobe_pdf_api_key = ENV["ADOBE_PDF_API_KEY"] |
Collaborator
There was a problem hiding this comment.
я не впевнений, що такі штуки тре в контроллері юзати-передавати
app/views/books/show.html.erb
Outdated
Comment on lines
43
to
56
| <script> | ||
| const previewConfig = { | ||
| showDownloadPDF: false, | ||
| showPrintPDF: false, | ||
| showAnnotationTools: false | ||
| } | ||
|
|
||
| document.addEventListener("adobe_dc_view_sdk.ready", function () { | ||
| var adobeDCView = new AdobeDC.View({ clientId: "<%= @adobe_pdf_api_key %>", divId: "pdf-viewer" }); | ||
| adobeDCView.previewFile({ | ||
| content: { location: { url: "<%= rails_blob_path(@book.content, only_path: true) %>" } }, | ||
| metaData: { fileName: "<%= @book.content.filename %>" }, | ||
| }, previewConfig); | ||
| }); |
Collaborator
There was a problem hiding this comment.
стімулус контроллери для кого?))
Comment on lines
14
to
18
| if user.present? && book.content.attached? | ||
| expect(rendered).to include("src=\"https://documentcloud.adobe.com/view-sdk/main.js\"") | ||
| else | ||
| expect(rendered).not_to include("src=\"https://documentcloud.adobe.com/view-sdk/main.js\"") | ||
| end |
Collaborator
There was a problem hiding this comment.
це ще що таке?) то щось не гуд
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added PDF viewer to the Show page with Adobe PDF Embed API.
Add view test.
PDF Viewer on show book page.
No download or print option
Book content only visible for authorised users.
