Feature/elasticsearch chewy #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loqimean
requested changes
Nov 28, 2023
| end | ||
|
|
||
| def search | ||
| @search_query = params[:search][:query] |
Collaborator
There was a problem hiding this comment.
а якщо сьорч поверне ніл?
app/services/book_search.rb
Outdated
| def self.search(query) | ||
| search_results = BooksIndex.query(query_string: {fields: [:title, :author, :description], query: query}).to_a | ||
| book_ids = search_results.map(&:id) | ||
| Book.where(id: book_ids) |
Collaborator
There was a problem hiding this comment.
не тре цього, це не оптимально
| @@ -0,0 +1,6 @@ | |||
| <%= simple_form_for :search, url: search_books_path, method: :get, html: { class: "flex items-center" } do |f| %> | |||
Collaborator
There was a problem hiding this comment.
огорни у семантичний тег search
config/environment.rb
Outdated
| # Initialize the Rails application. | ||
| Rails.application.initialize! | ||
|
|
||
| BooksIndex.import(force: true) |
|
|
||
| before(:each) do | ||
| BooksIndex.reset | ||
| BooksIndex.import(force: true) |
Owner
Author
There was a problem hiding this comment.
щоб ресетнути індекс і заповнити його актуальними даними перед тестами?)
spec/services/book_search_spec.rb
Outdated
|
|
||
| describe ".search" do | ||
| it "returns books matching the query" do | ||
| search_results = BookSearch.search("ruby") |
Collaborator
There was a problem hiding this comment.
а лет і сабджект для кого?))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Chewy Gem
Add Search Functionality
Change views to add search bar and search results
Add Active Storage Validations Gem to validate attachments
Add tests
User can search books by book name, author and words that may be in description.
Search by book name:
Search by author:
Search by any word may be in description:
If the search doesn't find anything it redirects to main page and shows notice:
If the search query is empty it redirects to main page and shows notice:
