Add optional documentation to declaration items in (decl) form. #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispbub
reviewed
Sep 26, 2025
Owner
Author
|
@lispbub This is the version as discussed, can you give it a quick look? The following image shows execution times on a current project for running a few files through C-Mera (20 invocations of the same set). The compiled version got quite a bit slower, but using interpretation (see #104) there is not much of a difference. 
|
lispbub
reviewed
Nov 24, 2025
| `(declaration-value (make-node ,init)) | ||
| nil)) | ||
| ,@(if comment | ||
| `((comment "//" ,comment nil))))))) |
Collaborator
There was a problem hiding this comment.
I really though you could split the comment from the declaration item.
Essentially emitting two nodes from one input.
Then there is no need for a dedicated comment pretty printer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only added support for this for
cm-candcm-cxx. If you feel that the changes are alright, then I'll fix the others.I mainly want to get your input on the pretty printer code. The outline is:
declaration-items, the traverser will not emit commentsdeclaration-itemis done and has a comment field, the comment is emitted after the;My main question is: is there a better way to do this? because getting the comment node itself and accessing the pretty printer was quite fiddely.