Mealie v2.0.0 Shopping List API Not Working with Mealient #335 #338
Mealie v2.0.0 Shopping List API Not Working with Mealient #335 #338Hyperion923 wants to merge 1 commit intokirmanak:masterfrom
Conversation
… new API endpoints
|
Hey @Hyperion923, here is an example of how you can ask me to improve this pull request: @Sweep Add unit tests for `MealieServiceKtor` that verify the correct API endpoints are being called with the new "/api/households/shopping/" prefix instead of "/api/groups/shopping/". This should include tests for all modified methods: 📖 For more information on how to use Sweep, please read our documentation. |
|
This already looks good to me :D But this PR would break the app for users still running mealie 1.x. I think a better approach would be to dynamically select the required endpoint based on the version of the mealie instance mealient is connected to. This can be done pretty easily as the version number is included in the What do you think about this? :-) I've already implemented this in my own fork HowRuck/Mealient@858e664 (unit tests and some polish still missing), but I am still working on another PR/feature that I want to complete before "pull requesting" upstream, which is why I haven't done so already. Feel free to use this code as a starting point if we decide to go that route :-) |
The endpoints for interacting with shopping lists have changed in Mealie. This may cause issues for users who have integrated with the Mealie API, particularly those using the shopping list functionality.
Previous Endpoints:
Example of an old endpoint:
/api/groups/shopping/listsNew Endpoints:
Example of an new endpoint:
/api/households/shopping/lists