Skip to content

⚡ Optimize FLV streaming cache to avoid large allocations #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kira1928 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

⚡ Optimize FLV streaming cache to avoid large allocations #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87f69aa
Optimize FLV streaming cache to avoid large allocations
google-labs-jules[bot] Jan 23, 2026
8179fe8
fix: address code review feedback
google-labs-jules[bot] Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/streaming_flv.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,12 @@ impl StreamingFlvParser {
let data = array.to_vec();

if request_len <= CACHE_CHUNK_BYTES {
*self.cache.borrow_mut() = Some(CachedChunk { offset, data: data.clone() });
let ret = data[..length.min(data.len())].to_vec();
*self.cache.borrow_mut() = Some(CachedChunk { offset, data });
Ok(ret)
} else {
Ok(data)
}
Comment on lines 214 to 220
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a great optimization! You can further simplify the code by extracting the duplicated logic to create the return value. This avoids repeating the slicing and allocation logic in both branches of the if statement, making the code cleaner.

        let ret = data[..length.min(data.len())].to_vec();
        if request_len <= CACHE_CHUNK_BYTES {
            *self.cache.borrow_mut() = Some(CachedChunk { offset, data });
        }
        Ok(ret)


Ok(data[..length.min(data.len())].to_vec())
}

/// 解析 FLV 头部
Expand Down