Skip to content

Conversation

@ntruchsess
Copy link

@ntruchsess ntruchsess commented Aug 11, 2023

What is the linked issue for this pull request:

QMS-Maproom#624

What you have done:

replaced the mutex-protected field 'synchronous' by a reply-property that doesn't require to be protected as qt takes care when delivering via signal.

Steps to perform a simple smoke test:

[comment]: # N/A, you cannot see the difference in the ui

Does the code comply to the coding rules and naming conventions Coding Guidelines:

  • yes

Is every user facing string in a tr() macro?

  • yes

Did you add the ticket number and title into the changelog? Keep the numeric order in each release block.

@ntruchsess ntruchsess changed the title QMS-624 fix BRouter synchronous request return value in case of error QMS-624 fix BRouter synchronous request return value 0 in case of error Aug 11, 2023
@ntruchsess ntruchsess changed the title QMS-624 fix BRouter synchronous request return value 0 in case of error [QMS-624] fix BRouter synchronous request return value 0 in case of error Aug 11, 2023
@ntruchsess
Copy link
Author

@kiozen while this is most likely not causing said crash it should be fixed as you are touching the affected code anyway

@ntruchsess ntruchsess changed the title [QMS-624] fix BRouter synchronous request return value 0 in case of error [QMS-624] fix BRouter mutex threading issues Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant