Skip to content

fix: use a proper way to set Timestamp param #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ETiV wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use a proper way to set Timestamp param #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions dist/base/BaseClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@ const getSignedParams = require('../lib/sign.js').getSignedParams;

const fetch = require('../lib/fetch.js');

const dayjs = require('dayjs');

const utc = require('dayjs/plugin/utc.js');

const qs = require('qs');

dayjs.extend(utc);
module.exports = class BaseClient {
constructor(clientConfig) {
_defineProperty(this, "_baseConfig", {});
Expand Down Expand Up @@ -43,7 +38,7 @@ module.exports = class BaseClient {
Service: this._baseConfig.config.credentials.service,
Action: apiAction,
Version: apiConfig.config.query.Version,
Timestamp: dayjs().utc().format('YYYY-MM-DDThh:mm:ss') + 'Z',
Timestamp: new Date().toISOString().replace(/\.\d{3}Z$/, 'Z'),
SignatureVersion: '1.0',
SignatureMethod: 'HMAC-SHA256',
Region: this.region || this._baseConfig.config.credentials.region
Expand Down
11 changes: 0 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"abort-controller": "^3.0.0",
"core-js": "^3.6.5",
"crypto-js": "^4.1.1",
"dayjs": "^1.10.7",
"node-fetch": "^2.6.7",
"qs": "^6.10.3"
},
Expand Down
8 changes: 2 additions & 6 deletions src/base/BaseClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
const getSignedParams = require('../lib/sign.js').getSignedParams
const fetch = require('../lib/fetch.js')
const dayjs = require('dayjs')
const utc = require('dayjs/plugin/utc.js')
const qs = require('qs')

dayjs.extend(utc)

module.exports = class BaseClient {
_baseConfig = {}
_apiList = {}
Expand All @@ -32,7 +28,7 @@ module.exports = class BaseClient {
Service: this._baseConfig.config.credentials.service,
Action: apiAction,
Version: apiConfig.config.query.Version,
Timestamp: dayjs().utc().format('YYYY-MM-DDThh:mm:ss')+'Z',
Timestamp: (new Date()).toISOString().replace(/\.\d{3}Z$/, 'Z'),
SignatureVersion: '1.0',
SignatureMethod: 'HMAC-SHA256',
Region: this.region || this._baseConfig.config.credentials.region,
Expand Down Expand Up @@ -89,4 +85,4 @@ module.exports = class BaseClient {
}
return JSON.stringify(signedParams)
}
}
}