Skip to content

Conversation

@ETiV
Copy link

@ETiV ETiV commented Aug 9, 2023

problems:

  1. The original code uses the wrong format 'hh' to present a 24-hour format date-time string, which is incorrect.
    It should be 'HH'.
  2. Since the dayjs module is the only used here, there's a simpler way to present the whole acceptable Timestamp string: (new Date()).toISOString(), then remove the millisecond part by .replace(/\.\d{3}Z$/, '').
    So I removed this dependency, and use (new Date()).toISOString().replace(/\.\d{3}Z$/, 'Z') here.

by the way:

when I run npm run build, there're other files and directories has been changed local on my disk, but I've just pick the files about I've modified to push.

Maybe the whole npm package should be upgraded completely by you, the maintainers. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant