Merged
Conversation
purushoath02
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds codes for ones, zeros, and also matmul
matmul is ~ to naive but this one takes advantage of cache so expect it to be a little bit more faster.
we need to have benchmark of some sort to test these. ofc we will improve matmul in future but lets make it less priority for now since we are will implement this in cuda as well (which is what we will be using)
but please check if everything is working or not.
thanks
updates:
after benchmarking with numpy
a = lm.ones((1000, 1000))
b = lm.ones((1000, 1000))
a@b
took 8sec while numpy took just 0.05 seconds
now i have done some optimizations and made it 4seconds and now 0.1 seconds. I will look into somemore optimizations but ig for now its fine. You can go ahead and merge if you think everything is alright.