Skip to content

feat: certifier otel metrics#155

Merged
gk-kindred merged 3 commits intomasterfrom
feature/certifier-otel-metrics
Apr 1, 2026
Merged

feat: certifier otel metrics#155
gk-kindred merged 3 commits intomasterfrom
feature/certifier-otel-metrics

Conversation

@gk-kindred
Copy link
Copy Markdown
Collaborator

Introduces the following Otel metrics in talos certifier

// Capture the time from initiator got the request to certify at the cohort till the `Candidate` arrived on certifier
talos_initiator_certifier_candidate_received

// Capture the time from the `Candidate` arrived on certifier to `Decision` created
talos_initiator_certifier_decision_created

// Capture the time from the `Candidate` arrived on certifier to `Decision` published.
talos_initiator_certifier_decision_published

// Capture the time from initiator got the request to certify at the cohort till the `Decision` was created on certifier
talos_certifier_candidate_received_decision_created

// Capture the time from initiator got the request to certify at the cohort till the `Decision` was published on certifier.
talos_certifier_candidate_received_decision_published

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 73.07692% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.53%. Comparing base (81b2279) to head (337db1d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/talos_certifier/src/otel.rs 0.00% 20 Missing ⚠️
...talos_certifier_adapters/src/certifier_kafka_pg.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   66.30%   66.53%   +0.23%     
==========================================
  Files         123      124       +1     
  Lines       12149    12195      +46     
==========================================
+ Hits         8055     8114      +59     
+ Misses       4094     4081      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gk-kindred gk-kindred marked this pull request as ready for review April 1, 2026 04:42
@simonol1
Copy link
Copy Markdown

simonol1 commented Apr 1, 2026

Looks good to me - no write access

@gk-kindred gk-kindred merged commit 5f2d7d0 into master Apr 1, 2026
9 checks passed
@gk-kindred gk-kindred deleted the feature/certifier-otel-metrics branch April 1, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants