Skip to content

chore: Bump to latest rust version 1.94 and publish beta tags from feature branch#154

Merged
gk-kindred merged 27 commits intomasterfrom
feature/rust-version-bump-1.94
Apr 1, 2026
Merged

chore: Bump to latest rust version 1.94 and publish beta tags from feature branch#154
gk-kindred merged 27 commits intomasterfrom
feature/rust-version-bump-1.94

Conversation

@gk-kindred
Copy link
Copy Markdown
Collaborator

@gk-kindred gk-kindred commented Mar 30, 2026

This PR introduces below changes

1. Bump rust version to 1.94

We have been on very old rust version for a long time (1.75). This leads to issues at the time of publishing due transient packages have MSRV 1.80+.

The following commits covers the changes related to this part.
7985e3a, dcde9a0, 5391c0d

dcde9a0 is to fix the lint change introduced in the newer versions of rust.

2. Make it easy to publish beta tags from feature branches.

Current workflow

  • master

    • current version - 0.3.14
    • Run release script
    • Bump version and tag to - 0.3.15 for publish
    • Create a new version 0.3.16-dev
  • feature branch currently:-

    • Try bumping version to 0.3.16-beta, fails at publishing at cargo publish step.
    • Run release script is forced to
    • publish 0.3.17 with tag from feature branch
    • create a new -dev version 0.3.18-dev
    • Merging the feature branch back to master
    • shows the 2 commits related to version bump and updates the versions on master

Proposed solution

  • master
    • current version - 0.3.14
    • Run release script to bump version and tag to 0.3.15 for publish

-feature branch proposed

  • Tag a commit with -beta version. eg. 0.3.16-beta.0
  • Push the commits and tag
  • Github action detects the tag, and runs the publish action
  • For beta tags, bump the versions in package.json and cargo.toml
  • This leaves dirty changes on the github runner but not commited.
  • Publish the packages under 0.3.16-beta.0
  • The feature branch doesn't have these changes/commits and therefore when merging this branch to master, we don't see 0.3.16-beta.0 in the master branch. Keeping the versions and commits clean at the same time make it flexible and easy to publish -beta tags from feature to test a feature/change.

An advantage with the proposed solution is we don't bump too many unwanted versions from feature branch just to test a feature.

3. Fix code coverage github action and capture codecoverage

Code coverage was silently broken for sometime. Bumping to rust version 1.94 had minor changes around the code coverage, which is fixed and improved.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.30%. Comparing base (bc281df) to head (c0a2da7).
⚠️ Report is 242 commits behind head on master.

Files with missing lines Patch % Lines
packages/cohort_banking/src/bin/preload_db.rs 0.00% 2 Missing ⚠️
...s/examples_support/src/load_generator/generator.rs 0.00% 2 Missing ⚠️
packages/cohort_banking/src/metrics.rs 0.00% 1 Missing ⚠️
packages/talos_certifier/src/healthcheck.rs 0.00% 1 Missing ⚠️
.../src/bin/histogram_decision_timeline_from_kafka.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   56.95%   66.30%   +9.34%     
==========================================
  Files         113      123      +10     
  Lines        5708    12149    +6441     
==========================================
+ Hits         3251     8055    +4804     
- Misses       2457     4094    +1637     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gk-kindred gk-kindred requested a review from akaur13 March 31, 2026 22:00
@gk-kindred gk-kindred merged commit 81b2279 into master Apr 1, 2026
4 checks passed
@gk-kindred gk-kindred deleted the feature/rust-version-bump-1.94 branch April 1, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants