feat: deserialise messenger on_commit actions using RawValues#129
Draft
gk-kindred wants to merge 1 commit intomasterfrom
Draft
feat: deserialise messenger on_commit actions using RawValues#129gk-kindred wants to merge 1 commit intomasterfrom
gk-kindred wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serde_json::Valueis very resource intensive. On a high load, lot of CPU is spend on deserialising the payload and the memory gets bloated. This has a direct impact on the overall throughput and latency messenger can achieve.Messenger only needs partially deserialisation at various points before the messages are finally send out by the kafka producer thread.
Therefore using
serde_json::RawValuesis more efficient on the memory and CPU and thereby has significant boost in performance on high load.