feat: base for back pressure in talos ecosystem and usage in messenger#128
Draft
gk-kindred wants to merge 4 commits intomasterfrom
Draft
feat: base for back pressure in talos ecosystem and usage in messenger#128gk-kindred wants to merge 4 commits intomasterfrom
gk-kindred wants to merge 4 commits intomasterfrom
Conversation
| pub is_enabled: bool, | ||
| /// Max count before back pressue is enabled. | ||
| /// if `None`, back pressure logic will not apply. | ||
| pub max_threshold: Option<u32>, |
Contributor
There was a problem hiding this comment.
If this is "max count" then its better if we named the attribute with workd "count" in it.
Please change the order.
is enabled
thencount and max count.
Comment on lines
+11
to
+12
| /// Batch of items to process, when back pressure is enabled before disable logic is checked? | ||
| /// if None, no minimum check is done, and as soon as the count is below the max_threshold, back pressure is disabled. |
Contributor
There was a problem hiding this comment.
Please have another look at the description. I am not able to follow the purpose of this parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TalosBackPressureConfigwhich could be added to any service in talos ecosystem with all the essential methods to capture and determine if back pressure is required.TalosBackPressureConfigin Talos messenger service.