Fix: Fix leak when image loading failes

[kimkulling]

Summary by CodeRabbit

• Refactor
  • Optimized internal processes for media handling to improve stability and maintainability.
  • These improvements ensure consistent performance with no user-facing changes.

[coderabbitai]

Walkthrough

The pull request refactors the loadIntoImageCache function in src/widgets.cpp. The function now initializes the width, height, and bytes per pixel variables to zero at declaration rather than later, and the allocation of the Image object is moved to occur after these initializations. Additionally, the immediate null check after allocation has been removed, simplifying error handling. The overall control flow of the function remains unchanged.

Changes

File	Change Summary
src/widgets.cpp	Refactored loadIntoImageCache: initialized w, h, and bytesPerPixel at declaration, moved Image allocation after initialization, and removed the immediate null check for error handling.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant loadIntoImageCache as Function
    Caller ->> Function: call loadIntoImageCache()
    Function ->> Function: initialize w, h, bytesPerPixel = 0
    Function ->> Function: allocate Image object
    Function ->> Function: (skip null check)
    Function ->> Function: cache image
    Function -->> Caller: return image (or error)

Loading

Poem

Hoppity, I scurry through the code,
With variables fresh and everything in mode.
The Image hops in without a doubt,
No null check to fuss about.
I nibble bugs in glee today—
A bunny's tune in a coding ballet!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b636f70 and b08f1cf.

📒 Files selected for processing (1)

• src/widgets.cpp (1 hunks)

🧰 Additional context used

🧬 Code Definitions (1)

src/widgets.cpp (1)

src/backends/sdl2_renderer.h (1) (1)

• data (87:87)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (1)

src/widgets.cpp (1)

59-67: Good fix for preventing memory leak during image loading failure.

The changes to the loadIntoImageCache function correctly prevent a memory leak by:

1. Initializing width, height, and bytesPerPixel to zero at declaration
2. Moving the Image allocation (new Image) to after the stbi_load error check

This ensures that memory for the Image object is only allocated if the image data was successfully loaded, preventing a leak if stbi_load fails.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud