Skip to content

vcpkg: latest greatest #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimkulling wants to merge 3 commits into
base: main
Choose a base branch
from
Open

vcpkg: latest greatest #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe81038
vcpkg: latest greatest
kullingk Dec 17, 2025
feebbac
Fix compile script
kullingk Dec 17, 2025
cb6583c
Make shader argument optional and add platform checks
kimkulling Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/compile_shader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from os import listdir
from os.path import isfile, join

TargetFolder =
Copy link

@coderabbitai coderabbitai bot Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Invalid syntax prevents script execution.

Line 10 has an incomplete assignment statement TargetFolder = with no value, causing a syntax error that prevents the script from running. Additionally, this variable is never used elsewhere in the code.

Remove this line entirely or complete the implementation if it was intended to store the target folder path.

🔎 Proposed fix 
-TargetFolder =
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
TargetFolder =
🧰 Tools
🪛 Ruff (0.14.10)

10-11: Expected an expression

(invalid-syntax)

🤖 Prompt for AI Agents 
In scripts/compile_shader.py around line 10 there is an incomplete assignment
"TargetFolder =" that causes a SyntaxError and the variable is unused; either
delete this line entirely if not needed, or set it to a valid string/path (e.g.
TargetFolder = "/path/to/target") and update the rest of the script to reference
it where appropriate so the variable is actually used and no syntax error
remains.

def compile_shader(shadername, shader_out, verbose):
if len(shadername) == 0:
return
Expand Down Expand Up @@ -49,8 +50,12 @@ def main():
path = Path(shader)
shader_out = path.suffix[1:len(path.suffix)] + ".spv"
compile_shader(args.shader + shader, shader_out, args.verbose)

copy_shader(shader_out, "../bin/debug/shaders")
if os.name == 'nt':
copy_shader(shader_out, "../bin/debug/shaders")
elif os.name == 'posix':
copy_shader(shader_out, "../bin/shaders")
else:
print('Error: unknown platform')

if __name__=="__main__":
main()
Expand Down
2 changes: 1 addition & 1 deletion src/contrib/vcpkg
Open in desktop
Submodule vcpkg updated 4469 files
Loading