Feature/add uniform buffers

[kimkulling]

Summary by CodeRabbit

• Refactor
  • Upgraded 3D rendering engine to use uniform buffer objects for efficient management of model, view, and projection transformations
  • Implemented descriptor pool and descriptor set management for optimized GPU resource binding
  • Refined draw command architecture for improved rendering pipeline integration

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes integrate Vulkan descriptor sets and uniform buffer objects into the renderer. A new uniform block in the vertex shader receives model-view-projection matrices. The Vulkan implementation adds descriptor set layout, descriptor pool, and per-frame uniform buffers with creation, initialization, and update methods. The DrawCommand struct removes its rpState member.

Changes

Cohort / File(s)	Summary
Vertex Shader Updates assets/shaders/default.vert	Added UniformBufferObject uniform block (binding 0) with model, view, and proj matrices; updated vertex position calculation to use UBO matrices.
Vulkan Renderer Implementation src/runtime/renderer/RHIVulkan.cpp	Added descriptor set layout, descriptor pool, and per-frame uniform buffers with state members. Introduced methods for creating descriptor layouts, uniform buffers, descriptor pools, and descriptor sets, and updating UBO with time-based rotation and view/projection matrices. Updated initialization and shutdown flows to manage new descriptor resources. Modified draw sequence to bind descriptor sets before drawing. Changed front face winding to counter-clockwise.
Renderer Interface Changes src/runtime/renderer/rendercore.h	Removed rpState member from DrawCommand struct (now commented out).
Dependency Updates src/contrib/cppcore	Submodule pointer updated to new commit.

Sequence Diagram(s)

sequenceDiagram
    participant Init as Initialization
    participant Render as Per-Frame Render
    participant GPU as GPU Pipeline
    
    rect rgb(220, 240, 255)
    Note over Init: Initialization Phase
    Init->>Init: createDescriptorSetLayout()
    Init->>Init: createUniformBuffers() (3 frames)
    Init->>Init: createDescriptorPool()
    Init->>Init: createDescriptorSets()
    end
    
    rect rgb(220, 255, 240)
    Note over Render: Per-Frame Phase
    Render->>Render: updateUniformBuffer(currentFrame)
    Note right of Render: Fill with rotation, view, proj
    Render->>Render: vkCmdBindDescriptorSets()
    Render->>GPU: vkCmdDrawIndexed()
    end
    
    rect rgb(255, 240, 220)
    Note over Init: Shutdown Phase
    Init->>Init: Destroy uniform buffers
    Init->>Init: Destroy descriptor pool
    Init->>Init: Destroy descriptor set layout
    end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

• RHIVulkan.cpp: Substantial additions including five new methods (createDescriptorSetLayout, createUniformBuffers, createDescriptorPool, createDescriptorSets, updateUniformBuffer) with non-trivial Vulkan semantics; requires careful verification of descriptor set management, memory allocation/deallocation, and per-frame UBO update logic.
• Integration points: Changes to initialization flow, draw sequence, and shutdown flow require tracing state dependencies and resource lifecycle.
• Shader-to-renderer coupling: Verify consistency between UBO layout in shader and structure passed to Vulkan (model, view, proj ordering and alignment).
• Removed rpState: Confirm that removal from DrawCommand doesn't break existing render state application elsewhere in the pipeline.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/add_uniform_Buffers

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4d0918 and cafaa2b.

📒 Files selected for processing (4)

• assets/shaders/default.vert (1 hunks)
• src/contrib/cppcore (1 hunks)
• src/runtime/renderer/RHIVulkan.cpp (13 hunks)
• src/runtime/renderer/rendercore.h (1 hunks)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud