Disgusting protocol cleanup #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimden
force-pushed
the
disgusting-protocol-cleanup
branch
from
27944dd to
1348ff7
Compare
kimden
added
T: improvement
kimden
force-pushed
the
disgusting-protocol-cleanup
branch
from
7937e28 to
02a1972
Compare
kimden
force-pushed
the
disgusting-protocol-cleanup
branch
from
418d757 to
c1f6fba
Compare
(due to pretty much everything being interconnected, I'll continue later if I can) [skip ci]
[skip ci] because the road to successful compilation is very long
[skip ci, not able to build yet]
[skip ci] It's getting slightly annoying tho with all those 'arbitrary' options. I should reconsider some syntax things
Had also to move some things in packets and network string, they also accidentally included each other
The next step is making sure types in packets are differentiated by their encoding/decoding method
Not everything of course is implemented, bugs exist too, in particular, ownerless start button doesn't work after racing
It broke server joining for now
I got very confused but somehow it works. Live join doesn't though. Client not tested yet, should be horrible right now.
…tion broken [skip ci]
[skip ci]
[skip ci]
[skip ci] for now
… exceptions [skip ci]
kimden
force-pushed
the
disgusting-protocol-cleanup
branch
from
54eb295 to
f89d8fa
Compare
- Move sendString, sendPacket to Comm:: - Keep sendPacketPtr, sendNetstring to STKHost - Leave a few sendNetstring-s in Comm:: as deprecated. [skip ci]
kimden
force-pushed
the
disgusting-protocol-cleanup
branch
from
056cb3d to
7196df9
Compare
[skip ci] You look at GameProtocol's network packet formation. It is confusing. The order of things is confusing. You look at places where it's decoded. They are confusing. You look at places where the decoded packet is applied. They are of a base class which means you'll still have to work on them, but for now, you can do nothing without diving deep into them. You look at the rest of code, and you see a map from network packet encoded as array of uint8_t encoded as string. I would like to express my profound gratitude to creators of this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful compilation doesn't mean working code
Agreement