Conversation
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 92.12% 91.37% -0.76%
==========================================
Files 12 13 +1
Lines 432 452 +20
==========================================
+ Hits 398 413 +15
- Misses 34 39 +5
Continue to review full report at Codecov.
|
|
I dont really see the difference with this PR and #42. It seems like CacheContainer is just an extra layer, since it is only used when plane stress is needed? So the resulting solver_cache() and plane_stress_cache() just becomes extra boilerplate. Also, the material_response(::Plastic...) seems to also get the PlateStress cache, which it will never need. Tbh, I think it is okay if we skip making the plane stress iterations allocation free, since it seems to complicate the code to much :P |
Counter suggestion for #42