Conversation
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 92.07% 91.74% -0.34%
==========================================
Files 11 12 +1
Lines 404 436 +32
==========================================
+ Hits 372 400 +28
- Misses 32 36 +4
Continue to review full report at Codecov.
|
Collaborator
Author
|
Seems to be type stable: |
Owner
|
Though this would mean that the dimension is not available at compile time anymore I think. Perhaps fixable by defining getdim(::Type{UniaxialStrain}) = 1and so on? |
Collaborator
Author
|
Hmm, if I remember correctly it everything was type-stable. Maybe because it is a singleton? I can double check |
Owner
|
What would I use for generic 2D cases that are neither plane strain nor plane stress now (like 2D cohesive elements)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a bit cleaner like this I think :)