Conversation
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
- Coverage 94.87% 94.06% -0.81%
==========================================
Files 10 11 +1
Lines 351 354 +3
==========================================
Hits 333 333
- Misses 18 21 +3
Continue to review full report at Codecov.
|
|
With this all routines would always return some (possibly empty) on a material that has extras defined is not possible? |
|
A material that has extras defined could also define the "normal" material_response routine ( |
|
Ultimately we should just decide for a way to handle it now and try it out. If it breaks down for some use-case we worry about it with a concrete problem at hand. I think we should have a unit test for the fallback of |
A way for the user to request extra ouput variables from the material routine.
Instead of calling
s, ds, state = material_routine(mat, strain, dt)they can call
s, ds, state, extras = material_routine(mat, starin, dt, :extras)(Similar to how tensors export both gradient and residuals from by adding
:allin the arguement list)Should generate typestable code.
Does not affect the implementation of exciting or new materials (unless the material should output extra variables).
(Some code should be added for 2d-materials, but that could be done later)