Merged
Conversation
Merges Clever/saml2 changes including: - Upgrade to xml-crypto 6.1.2 (fixes uri handling issue) - Use official xpath library - New signedReferences API Preserves Kiln-specific features: - idp_entity_id validation (issuer checking) - @flourish/saml2-js package name Resolves conflicts: - Removed .circleci/config.yml (not used by Kiln) - Merged package.json with Kiln name and version 4.2.0 - Used upstream's xpath import approach
guyneedhamcanva
force-pushed
the
guyn-update-fork-from-upstream
branch
from
61e8348 to
bd95f1a
Compare
jontyt
approved these changes
Jan 28, 2026
jontyt
left a comment
jontyt
left a comment
There was a problem hiding this comment.
Yuck that we have this as a fork, but LGTM if works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our fork is way way behind. This brings a bunch of updates from https://github.com/clever/saml2 into our fork, updating deps and fixing some issues. Takes us to 4.2.0. Upstream is now in maintenance mode so we should take a look at alternatives.