-
-
Notifications
You must be signed in to change notification settings - Fork 148
feat: preview thumbnail when hovering over seek bar #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks @RonzyOnGIT this is pretty cool
|
Thanks for taking a look at it! Regarding memory usage, one alternative I had in mind was creating a pre-generated sprite sheet, completely removing the need for a second video file. The issue with that is that there would be a need for a server to handle the video processing such as ffmpeg to generate frames. I really love this project — thanks for all the work you’ve put into it. I’m excited to keep contributing where I can. I'll mark the pr as a draft for now. |
Of these options, I think it might be best to either:
The other options look pretty hairy to implement, as you need to consider how to calculate the intersection between the thumbnail and the subtitles.
I think I just need to profile on different browsers. The memory usage is probably not a big deal and maybe we could add a setting to disable the thumbnail entirely. |
* feat(dictionary): cache tokens in IndexedDB * use anki decks in addition to anki fields * use DictionaryProvider * update DictionaryProvider subscription api and cleanup code * remove _updateSuspendedCards() and cleanup code * Anki cache build state updates are structured --------- Co-authored-by: R-J Lim <kgerbil@gmail.com>
* export/import local tokens * collect tokens locally based on hovered element * import words from clipboard * support ignored * add more helper text for buildAnkiCache and disable if no tracks are enabled * highlight token on hover * return objects for dictionary query results
* add support for iWantTFC * add icon and some page settings * Fix formatting with prettier * Thank new contributor danthemango --------- Co-authored-by: R-J Lim <kgerbil@gmail.com>
* Rearrange annotation settings * Address feedback + additional changes to import dialog - Moved word DB buttons back to top - Removed track selector from import dialog because local tokens are trackless - Maturity + state inputs are displayed lazily, after previewing, since those options are not applied to 'import from file' * Restore track selector as 'yomitan api URL' selector in import dialog * Only lemmatize if imported record does not already have lemmas * Address feedback - split clipboard string before tokenize bulk - use Partial<DictionaryTokenRecord> - lemmatize imported file records only if lemmas are missing * Fix keyboard shortcut tab not scrolling when navigated to from dictionary settings
Co-authored-by: killergerbah <2254858+killergerbah@users.noreply.github.com>
What this does
Notes | limitations
Found cached image and accurate frame
First cache miss, the whole cache is empty
When you hover along the seekbar fast, shows last found cached image. Since there is no re-render, will not show the correct thumbnail unless you re-hover after image is rendered