Skip to content

added github actions#1

Merged
kihuha merged 6 commits intomainfrom
dev
Feb 10, 2026
Merged

added github actions#1
kihuha merged 6 commits intomainfrom
dev

Conversation

@kihuha
Copy link
Owner

@kihuha kihuha commented Feb 10, 2026

No description provided.

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
darkan-fin Ready Ready Preview, Comment Feb 10, 2026 5:30am

Request Review

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions workflow to run frontend linting, type-checking, unit tests, and upload coverage on pushes/PRs targeting main and dev.

Changes:

  • Introduces a CI job matrix to test on Node.js 18 and 20.
  • Runs lint, typecheck, and test:ci scripts.
  • Uploads Jest coverage output to Codecov.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +30 to +42
cache: "npm"

- name: Install dependencies
run: npm ci

- name: Run linting
run: npm run lint

- name: Run type checking
run: npm run typecheck

- name: Run tests with coverage
run: npm run test:ci
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow uses npm ci and cache: "npm", but the repo has a yarn.lock and no package-lock.json, so this job will fail (npm ci requires a lockfile). Align the workflow with the repo’s package manager (e.g., switch to Yarn with cache: "yarn" and yarn install --frozen-lockfile, or commit a package-lock.json and keep npm).

Suggested change
cache: "npm"
- name: Install dependencies
run: npm ci
- name: Run linting
run: npm run lint
- name: Run type checking
run: npm run typecheck
- name: Run tests with coverage
run: npm run test:ci
cache: "yarn"
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Run linting
run: yarn lint
- name: Run type checking
run: yarn typecheck
- name: Run tests with coverage
run: yarn test:ci

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +6
name: Frontend Tests & Quality Checks

on:
push:
branches:
- main
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an explicit permissions: block (e.g., contents: read) to follow least-privilege defaults for this workflow, since it only needs to checkout and run tests/upload coverage.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@kihuha kihuha merged commit 8977593 into main Feb 10, 2026
5 checks passed
@kihuha kihuha deleted the dev branch February 10, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants