[drools-lsp-52] Update grammars to the latest#54
Conversation
- Taken grammar files from drools repo - Removed parser/visitor tests - Updated JDK from 11 to 17
|
Hmm, test on mac is unstable? |
tkobayas
force-pushed
the
drools-lsp-52-update-grammar-2
branch
from
ccb65f4 to
a971e65
Compare
|
@mariofusco @gitgabrio Please review, thanks! |
| DRL_SALIENCE : 'salience'; | ||
| DRL_ENABLED : 'enabled'; | ||
| DRL_NO_LOOP : 'no-loop'; | ||
| DRL_AUTO_FOCUS : 'auto-focus'; | ||
| DRL_LOCK_ON_ACTIVE : 'lock-on-active'; | ||
| DRL_REFRACT : 'refract'; | ||
| DRL_DIRECT : 'direct'; | ||
| DRL_AGENDA_GROUP : 'agenda-group'; |
There was a problem hiding this comment.
@tkobayas I can't find the any documentation for dropping agenda-goup - I fell like I saw some something way back when 10.0.0 was released but can't find it now. Is agenda-group deprecated? We have it in some very old rules which still seem to work on drools 10.0.1, but the new parser doesn't like it. Should we be migrating this?
There was a problem hiding this comment.
@daniel-clark-mint Yes, the new language level DRL10 drops agenda-goup, because ruleflow-goup completely works as the same as agenda-goup. So the migration is just to replace agenda-goup with ruleflow-goup in your DRL.
Note that in Drools runtime, DRL6 is still the default, so your DRL will work fine with 10.2.0. But in the future, we will make DRL10 default, and finally drop DRL6.
It's my bad that I missed to mention about agenda-goup in the document and the release notes. I will work on the doc fix.
https://kie.apache.org/docs/10.1.x/drools/drools/release-notes/index.html#_10_1_0_release_notes
https://kie.apache.org/docs/10.1.x/drools/drools/language-reference/index.html#language-level_drl-rules
There was a problem hiding this comment.
Filed GH issue for doc : apache/incubator-kie-drools#6635
There was a problem hiding this comment.
Perfect, thank you for the update @tkobayas ! That cleared up the syntax errors from the DRL10 LSP service.
3 participants
drools-drl-parser. When drools10.1.0is released, we will be able add the dependency. Probably we will revisit if we want to use the dependency or keep the grammar files because we may want to customize the grammar files to support requirements from LSP clients (DRL Editor).