Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces multiline cell rendering in tirenvi.
Cells containing line breaks (
\n) are now rendered across multiple rows, enabling more natural and readable table editing.Key Changes
\n)Design Notes
Multiline rendering is treated as a core rendering model, not an optional feature
Each visual row is internally linked using a continuation flag
Buffer access is optimized via a single-chunk cache tailored for directional scanning
This implementation serves as a foundation for upcoming features, such as:
Scope
This PR focuses on:
It does not yet include:
Testing
Added/updated test cases for buffer access and cache behavior
Verified correct behavior for:
Notes
This PR restructures part of the rendering pipeline, so reviewing the overall flow (rather than individual diffs) may be helpful.