fix(metrics): resolve 3 GUI stats accuracy bugs#144
Merged
Conversation
- Cache hit rate no longer excludes zero-cache requests from denominator (was inflating 40% real rate to ~78%) - avgTokensPerSec now filters out timed-out/aborted entries (0 tok/s), matching per-model stats behavior - avgCacheHitRate now uses same 1000-entry window as token totals, eliminating scope mismatch with the 50-entry recent requests window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
avgTokensPerSecdragged down by timed-out/aborted entries (0 tok/s)avgCacheHitRateused 50-entry window while token totals used 1000-entry windowChanges
_nonZeroTpsCountrunning counter to track entries withtokensPerSec > 0_totalCacheReadTokens / totalInputAll)Closes #133
Test plan
npm run build— no type errorsnpx vitest run— 261/261 tests pass