Skip to content

Remove hard coded codes in digitalLED, whenButton #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neosarchizo wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Remove hard coded codes in digitalLED, whenButton #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions arduino_extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,10 +431,10 @@
ext.digitalLED = function(led, val) {
var hw = hwList.search(led);
if (!hw) return;
if (val == 'on') {
if (val == menus[lang]['outputs'][0]) {
digitalWrite(hw.pin, HIGH);
hw.val = 255;
} else if (val == 'off') {
} else if (val == menus[lang]['outputs'][1]) {
digitalWrite(hw.pin, LOW);
hw.val = 0;
}
Expand All @@ -449,9 +449,9 @@
ext.whenButton = function(btn, state) {
var hw = hwList.search(btn);
if (!hw) return;
if (state === 'pressed')
if (state === menus[lang]['btnStates'][0])
return digitalRead(hw.pin);
else if (state === 'released')
else if (state === menus[lang]['btnStates'][1])
return !digitalRead(hw.pin);
};

Expand Down