Add Codable Conformance
#3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done quickly and seems to work, though I haven't added any tests.
Owner
|
this PR is causing me a lot of internal strife because there are a few bugs in this library (namely with the variadic initializer and operator support) and https://github.com/pointfreeco/swift-nonempty is better in some ways (more compiler safe), and i don't have a ton of time to fix this up. i do want tests before we merge this but i also don't want to suggest to anyone that this is really production ready. |
Author
|
Cool. If I get some time soon, I'll add some tests. but don't feel any obligation to merge on my behalf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be flippant, but I was curious to use this class, but I needed codable conformance. I added it, and thought I'd express my appreciation by sharing it.
However, this was done quickly and while it seems to work, I haven't added any tests.